Go mod files #1282
Merged
Go mod files #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go modules are fine and it seems that Sarama already uses semver for release versioning and tags. looks good to me 👍 |
|
Thanks for contributing @ebati 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
go.sum&go.modfiles and exportedGO111MODULES=onin makefile. Since go1.10 cannot usego.modingo getit will download the latest version but go1.11 and later will usego.mod. Aftergo1.12release i can updatemakefileand travis config to usego mod verifyetc.We can also move
errcheckdependency totools.go( as detailed in here ) instead of separately installing it. Let me know if you prefertools.goapproach.(Fixes #1272)