Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling the regular expression every time it is consumed is redundant. #2662

Closed
qshuai opened this issue Oct 8, 2023 · 0 comments · Fixed by #2663
Closed

Compiling the regular expression every time it is consumed is redundant. #2662

qshuai opened this issue Oct 8, 2023 · 0 comments · Fixed by #2663

Comments

@qshuai
Copy link
Contributor

qshuai commented Oct 8, 2023

Description

The target code:

sarama/utils.go

Line 302 in 44f6db5

if !regexp.MustCompile(pattern).MatchString(s) {

The function regexp.MustCompile(pattern) will comiple the specified pattern when consuming every time. It is not CPU friendly.

The following is the part of CPU profile(Flame Graph) in production environment. It accounts for 7.6% in CPU usage and should be optimized.
cpu profile
qshuai added a commit to qshuai/sarama that referenced this issue Oct 8, 2023
@qshuai
fix: compile regex pattern redundantly when parsing kafka version(IBM…
009dfc5 
…#2662)
qshuai added a commit to qshuai/sarama that referenced this issue Oct 8, 2023
@qshuai
fix: compile regex pattern redundantly when parsing kafka version(IBM…
5521b99 
…#2662)

Signed-off-by: qshuai <qishuai231@gmail.com>
qshuai added a commit to qshuai/sarama that referenced this issue Oct 11, 2023
@qshuai
fix: compile regex pattern redundantly when parsing kafka version(IBM…
5e59c46 
…#2662)

Signed-off-by: qshuai <qishuai231@gmail.com>
dnwe pushed a commit to qshuai/sarama that referenced this issue Oct 11, 2023
@qshuai @dnwe
fix: compile regex pattern redundantly when parsing kafka version(IBM…
85092cc 
…#2662)

Signed-off-by: qshuai <qishuai231@gmail.com>
@dnwe dnwe mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pre-compile regex for parsing kafka version qshuai/sarama
1 participant
@qshuai