Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper mock expectations in SyncProducer.SendMessages #1035

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Proper mock expectations in SyncProducer.SendMessages #1035

merged 2 commits into from
Feb 6, 2018

Commits on Feb 6, 2018

  1. Proper mock expectations in SyncProducer.SendMessages 

    Fixing incorrect expectations checking for the SyncProducer mock
in SendMessages call.

1) SendMessages now checks the CheckFunction on each and
every single message/expectation. It's consistent with singular
SendMessage mocked implementation.

2) SendMessages now correctly copies the right size of expectations
to use when matching with produced messages. Fixes off by one error.
    @lieskovsky
    lieskovsky committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    c7d4e04 View commit details
    Browse the repository at this point in the history

  2. Increase test coverage of SyncProducer

    @lieskovsky
    lieskovsky committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    e9f0281 View commit details
    Browse the repository at this point in the history