Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kafka 0.10, add go 1.10 #1064

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Drop kafka 0.10, add go 1.10 #1064

merged 1 commit into from
Mar 15, 2018

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Mar 7, 2018

No description provided.

@eapache
Copy link
Contributor Author

eapache commented Mar 7, 2018

Looks like gzip encoding has changed again in Go 1.10. Sigh.

@ctrochalakis
Copy link
Contributor

Looks like gzip encoding has changed again in Go 1.10. Sigh.

Since support for go 1.7 is dropped (and tests in Go 1.7 are already failing, due to the missing sort.Slice), there is probably no need to maintain the pre1.8 gzip message.

@ctrochalakis ctrochalakis mentioned this pull request Mar 9, 2018
Merged
@eapache eapache merged commit 102a489 into master Mar 15, 2018
@eapache eapache deleted the bump-ci branch March 15, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eapache @ctrochalakis