Fix block on control messages #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the skip for those block to after the point where we've parsed/incremented the offset so we don't get stuck on a response containing *only* control messages.
|
tested against my topic i know trigger this. |
|
did not search too much for this but when sarama version < v0_11_0_0 we seem to enter at |
|
Since older versions of kafka don't have control messages, I don't believe it's possible to consume them from that version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the skip for those block to after the point where we've
parsed/incremented the offset so we don't get stuck on a response
containing only control messages.
Should fix #1106. @FrancoisPoinsot can you please confirm?