add customizable partitioner #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… most permutations of configurable elements
|
Ya, I was noticing this issue as well. In a from-scratch world (or if I ever do a major version bump) I think I might simply provide a single In the meantime, I suppose this is probably the best we can do. |
eapache
reviewed
Jun 15, 2018
partitioner.go
Outdated
| } | ||
| } | ||
|
|
||
| // WithCustomRandomPartitioner lets you specify what HashPartitioner should be used in case a Distribution Key is empty |
There was a problem hiding this comment.
s/HashPartitioner/Partitioner
eapache
reviewed
Jun 15, 2018
partitioner.go
Outdated
| } | ||
|
|
||
| // WithCustomRandomPartitioner lets you specify what HashPartitioner should be used in case a Distribution Key is empty | ||
| func WithCustomRandomPartitioner(randomHP *hashPartitioner) HashPartitionerOption { |
There was a problem hiding this comment.
I might call this WithCustomFallbackPartitioner
There was a problem hiding this comment.
makes much more sense, I'll update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the partitioner has a lot of different partitioner constructors now, and they contain functionality which cannot all be created without creating new custom constructor functions for each.
This PR introduces a customizable partitioner which works with functions as options. New added options will not break the current behavior nor will it break the function signature. That will let us introduce new options while we are still backwards compatible.
For reference:
https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis