Satisfy the error interface in create responses #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dnwe, can you please add some tests and we can merge it then? |
|
@varun06 thanks, rebased and re-pushed with some tests added |
Contributes-to: #1153 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
I'm not sure what the purpose of `TestClusterAdminCreateTopicWithDiffVersion` originally was, but rather than testing desired behaviour, it seemed to be asserting that a previous deficiency in the mockbroker responses would return an ErrInsufficientData because a V1 request got a V0 response from the mockbroker. Since ec2cbc3 the mockbroker responses with a matching response version to the original request, so this test would no longer pass its assertions and should be removed.
|
@varun06 travis build fixed after removing the test that is no longer valid |
|
Thanks, I will have a look today. |
varun06
approved these changes
Feb 25, 2019
sam-obeid
approved these changes
Feb 25, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes-to: #1153
Signed-off-by: Dominic Evans dominic.evans@uk.ibm.com