Fix consuming compacted topic #1227
Conversation
ghost
added
the
|
Does the test in linked PR cover this case too? |
|
@varun06 no, I will add the test if the community think this pr make sense |
|
What's the status of this PR? It fixes an issue we are currently having with sarama and goka |
|
If that's the case, let's get this PR passing and then we can ask it to be merged. |
|
Ok, I will try to get CI working =) PS: We used this fix in our fork since November, and it works great |
|
Nice, let's get CI working and then we can merge it. |
gburanov
force-pushed
the
fix_consuming_compressed_topic
branch
from
8a81924 to
36aaf2e
Compare
|
@varun06 I am a little bit concerned, why do I need to sign CLA https://cla.shopify.com/ for it? it is not mentioned in https://github.com/Shopify/sarama/blob/master/.github/CONTRIBUTING.md and as far as I understand sarama code is under MIT license... |
|
Are we just at a stalemate here or something? |
|
I am fine if somebody will just merge this pr for me - I do not want to sign CLA for this. CI is green expect CLA |
|
@bai What do you think? |
|
Thanks for contributing! |
See #1086 (comment) for details