Implement DescribeConfigs Request + Response v1 & v2 #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Mongey
force-pushed
the
cm-new-describe-configs
branch
from
982e35c
to
6f2ac05
Compare
1 task
Mongey
force-pushed
the
cm-new-describe-configs
branch
from
6f2ac05
to
b56869d
Compare
Mongey
force-pushed
the
cm-new-describe-configs
branch
4 times, most recently
from
b50a625
to
296e6cf
Compare
Mongey
changed the title
Mongey
force-pushed
the
cm-new-describe-configs
branch
2 times, most recently
from
08aded7
to
09b1c81
Compare
Mongey
force-pushed
the
cm-new-describe-configs
branch
from
09b1c81
to
f9494b4
Compare
|
Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to determine if a Topic Config is actually a Default in Kafka 1.0 and above. The Default value in the DescribeConfigResponse should really be deprecated, if < 1.0 is no longer supported.
Not quite sure what the new struct fields in DescribeConfigResponse should include
Configprefixes or not. (ConfigSourceConfigSynonmsetc)