adding version for zstd compression #1256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobrik does it look okay? |
bobrik
reviewed
Jan 17, 2019
| @@ -214,6 +212,8 @@ func (r *ProduceRequest) requiredVersion() KafkaVersion { | |||
| return V0_10_0_0 | |||
| case 3: | |||
| return V0_11_0_0 | |||
| case 4: | |||
There was a problem hiding this comment.
Shouldn't this be 7? See Kafka source.
I think you also need to update this code to start encoding with that version.
Ultimately you want to test this against a live v2.1.0 Kafka and see if that works.
|
Will bring it back once I have full understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issues mentioned in #1252