Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kafka test version #1273

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Update kafka test version #1273

merged 2 commits into from
Feb 8, 2019

Conversation

ebati
Copy link
Contributor

@ebati ebati commented Feb 7, 2019

I updated kafka version in provision.sh as 1.0.0 is not distributed here. Also the suggested version of scala is different for different versions as noted here. So added new environment variable which is used to find the recommended scala version while downloading kafka.

Kafka 1.0.0 is not available to download.
Recommended scala version is different for different versions of kafka
so new environment variable is added to supply recommended scala
version.
@ghost ghost added the cla-needed label Feb 7, 2019
@ebati
Copy link
Contributor Author

ebati commented Feb 7, 2019

I signed it.

@varun06
Copy link
Contributor

varun06 commented Feb 7, 2019

You might have to close and reopen again. Once the checks are passed, we can merge it.

@ghost ghost removed the cla-needed label Feb 7, 2019
@ebati ebati closed this Feb 7, 2019
@ebati ebati reopened this Feb 7, 2019
@varun06 varun06 requested a review from bai February 7, 2019 22:54
Copy link
Contributor

@varun06 varun06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bai
Copy link
Contributor

bai commented Feb 8, 2019

Thanks!

@bai bai merged commit b9359be into IBM:master Feb 8, 2019
@ebati ebati deleted the update-test branch February 8, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants