Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: include ReplicaAssignment in ListTopics() #1274

Merged
merged 1 commit into from
Feb 12, 2019
Merged

admin: include ReplicaAssignment in ListTopics() #1274

merged 1 commit into from
Feb 12, 2019

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Feb 8, 2019

Follow-on from #1155 / #1178 include the replica assignment information that we got back in the ListTopics() TopicDetail responses

Copy link
Contributor

@varun06 varun06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwe
Copy link
Collaborator Author

dnwe commented Feb 12, 2019

@varun06 thanks for the approval, were you waiting for another reviewer before merge?

@varun06
Copy link
Contributor

varun06 commented Feb 12, 2019

It is simple enough and I will merge it after another look today. In the mean time, if someone else want to review, that's great.

@varun06 varun06 merged commit ba151e1 into IBM:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants