Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed potential deadlock when a heartbeat request fails #1286

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

aksdb
Copy link
Contributor

@aksdb aksdb commented Feb 18, 2019

When using a ConsumerGroup I managed to block all but one consumers after Kafka went down (but Zookeeper kept running).

Test setup:

  • zookeeper + kafka
  • 1 partition
  • run a consumer multiple times, restarting as desired causing the group to be rebalanced (just in case)
  • kill kafka - one consumer properly leaves the "Consume" method while the others keep waiting

Debugging revealed that the "retries" went into negative numbers, simply because the failed retries were not evaluated at that point in the code. My PR adds this missing check and therefore allows a clean shutdown on a failed kafka connection.

@ghost ghost added the cla-needed label Feb 18, 2019
@aksdb
Copy link
Contributor Author

aksdb commented Feb 18, 2019

I signed the CLA but fail to see how I can rerun the check.

@ghost ghost removed the cla-needed label Feb 19, 2019
@bai
Copy link
Contributor

bai commented Feb 19, 2019

Thanks for contributing! I re-run the CLA check and all good.

@bai bai merged commit dca1ba6 into IBM:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants