Permit creating client with multiple broker addresses

[eapache]

Fixes #7

@burke @fw42

CC @tobi

This does the simplest thing that works. It has some flaws, but most
importantly it gets the API in place and is basically functional. We can
improve it later without breaking API compatibility.

Remaining sub-optimal behaviour:

• If the user provides three addresses, only the last of which is valid, we
  wait for the first two connections to completely fail (which may take several
  minutes depending on the TCP timeout) before we try the third. Trying them
  all in parallel and using the first valid one would be better.
• Once we've had an address fail, we discard it forever. Over the lifetime of a
  long-running cluster, all of the nodes may be down at one point or another,
  meaning that eventually we may 'run out' of nodes and abort. We should
  probably just mark the address as recently-failed, and retry them after some
  time has passed. Only if all nodes have recently failed should we abort.

[tobi]

Why use the flawed approach? Have a look how db.SQL does it.

-- Tobi
CEO Shopify

(mobile)

On Aug 15, 2013, at 7:00 AM, Evan Huus notifications@github.com wrote:

Fixes #7

@burke @fw42

CC @tobi

This does the simplest thing that works. It has some flaws, but most
importantly it gets the API in place and is basically functional. We can
improve it later without breaking API compatibility.

Remaining sub-optimal behaviour:

If the user provides three addresses, only the last of which is valid, we wait for the first two connections to completely fail (which may take several minutes depending on the TCP timeout) before we try the third. Trying them all in parallel and using the first valid one would be better.
Once we've had an address fail, we discard it forever. Over the lifetime of a long-running cluster, all of the nodes may be down at one point or another, meaning that eventually we may 'run out' of nodes and abort. We should probably just mark the address as recently-failed, and retry them after some time has passed. Only if all nodes have recently failed should we abort.
You can merge this Pull Request by running

git pull https://github.com/Shopify/sarama multiple_broker_client
Or view, comment on, or merge it at:

#13

Commit Summary

Permit creating client with multiple broker addresses
File Changes

M client.go (68)
M client_test.go (17)
M consumer_test.go (4)
M producer_test.go (4)
Patch Links:

https://github.com/Shopify/sarama/pull/13.patch
https://github.com/Shopify/sarama/pull/13.diff