Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More configuration #14

Merged
merged 2 commits into from
Aug 15, 2013
Merged

More configuration #14

merged 2 commits into from
Aug 15, 2013

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Aug 15, 2013

Add two more configuration options:

@burke @fw42

Evan Huus added 2 commits August 15, 2013 10:16
Add a StartingOffset config to the Consumer
541ea31 
Fixes #4

When #2 lands, we can define a constant for -1 that triggers sending an
OffsetFetchRequest without touching the API.
Add ProducerConfig.Compression
0465ed0
@burke
Copy link
Contributor

burke commented Aug 15, 2013

Looks good to me.

eapache added a commit that referenced this pull request Aug 15, 2013
@eapache
Merge pull request #14 from Shopify/more_configuration
b7d5358 
More configuration
@eapache eapache merged commit b7d5358 into master Aug 15, 2013
@eapache eapache deleted the more_configuration branch August 15, 2013 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual Consumer Offset Management
2 participants
@eapache @burke