Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the Kafka version in ListAcls method #1452

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Set the Kafka version in ListAcls method #1452

merged 2 commits into from
Aug 14, 2019

Conversation

symaras
Copy link
Contributor

@symaras symaras commented Aug 6, 2019

This PR adds a conditional to set the Kafka version. If the version is at last 2 then it sets request.Version = 1, which enables the functionality of getting the AclResourcePatternType field for the ACLs.

@ghost ghost added the cla-needed label Aug 6, 2019
@symaras symaras mentioned this pull request Aug 7, 2019
Closed
@symaras
Copy link
Contributor Author

symaras commented Aug 8, 2019

Not sure how to resolve these two errors:

  1. I signed the CLA already (attached a screenshot).
  2. I don't know why tests are failing; running 'go test' locally returns without errors.

Any help would be appreciated :)
CLA_signed

@ghost ghost removed the cla-needed label Aug 14, 2019
@bai
Copy link
Contributor

bai commented Aug 14, 2019

Thanks!

@bai bai merged commit 25c9059 into IBM:master Aug 14, 2019
@agapoff agapoff mentioned this pull request Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symaras @bai