Add support for Kafka 2.6.0 #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
approved these changes
Aug 5, 2020
| @@ -119,7 +119,7 @@ func prepareDockerTestEnvironment(ctx context.Context, env *testEnvironment) err | |||
| // found here: https://docs.confluent.io/current/installation/versions-interoperability.html | |||
| var confluentPlatformVersion string | |||
| switch env.KafkaVersion { | |||
There was a problem hiding this comment.
Need to remember to bump confluentPlatformVersion to 5.6 once images from that are available I guess. Probably worth opening a backlog issue so we don’t forget.
I did also wonder if we should move to strimzi/kafka for our CI image
There was a problem hiding this comment.
I see that we use a mix of confluent-oss and wurstmeister/kafka internally on CI. /cc @d1egoaz
There was a problem hiding this comment.
either should work, 🤷 ideally, we should only use one flavour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Kafka 2.6.0 🥗