Support Go 1.13 error unwrapping #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
The CI error does not seem to be related to my change: I there a way I could re-run the CI job? |
I've triggered the retry, looks green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little PR adding support for Go 1.13
errors.UnwraptoConsumerErrorandProducerError.This feature might be particularly useful for generic error handling code, such as when propagating custom errors from
Consumer.ConsumeClaim()or unit testing failure cases using mocks.I considered extending other error structs in the codebase but they either do not surface external or custom errors; or are aggregated errors that cannot have an unambiguous
Unwrap()result.I am not sure what tests might be useful for this change. Please let me know if any tests are needed.