Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly pass ValidateOnly through to CreatePartitionsRequest #1990

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

doxsch
Copy link
Contributor

@doxsch doxsch commented Jul 27, 2021

fix #1955

@doxsch doxsch requested a review from bai as a code owner July 27, 2021 07:17
@ghost ghost added the cla-needed label Jul 27, 2021
@doxsch
Copy link
Contributor Author

doxsch commented Aug 9, 2021

Hello @bai
Are there still concerns about this PR. Since this is a small bugfix, but it provides additional security in our environment, I would be happy if this PR could be merged in a timely manner.

Best thanks.

@ghost ghost removed the cla-needed label Aug 9, 2021
@dnwe dnwe changed the title Added ValidateOnly to CreatePartitionsRequest fix: correctly pass ValidateOnly through to CreatePartitionsRequest Aug 9, 2021
@dnwe
Copy link
Collaborator

dnwe commented Aug 9, 2021

@doxsch thanks for the PR, this is a good fix

Apologies for the delay, it’s Summer vacation season 🌞

@bai bai merged commit 387f1e2 into IBM:master Aug 9, 2021
@doxsch
Copy link
Contributor Author

doxsch commented Aug 9, 2021

You are right, of course. Excuse my impatience. Thanks for reviewing and merging. Have a nice summer. 😎

Do you already have a date for the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidateOnly when set true in CreatePartitions() is creating topic
3 participants