Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): correct wrong offsets in mock Consumer #2078

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

grongor
Copy link
Contributor

@grongor grongor commented Dec 4, 2021

I tested it with Kafka console producer/consumer and I think that this change is correct.

$ kafka-console-consumer --bootstrap-server ********** --version
6.2.1-ce (Commit:06652ad189d0cbf0)

$ kafka-console-consumer --bootstrap-server ********** --topic tmp.dummy --from-beginning --max-messages 1 --property print.offset=true
[2021-12-04 15:24:27,631] WARN [Consumer clientId=consumer-console-consumer-36100-1, groupId=console-consumer-36100] Error while fetching metadata with correlation id 2 : {tmp.dummy=LEADER_NOT_AVAILABLE} (org.apache.kafka.clients.NetworkClient)
^CProcessed a total of 0 messages

$ kafka-console-consumer --bootstrap-server ********** --topic tmp.dummy --from-beginning --max-messages 1 --property print.offset=true
^CProcessed a total of 0 messages

$ kafka-console-producer --bootstrap-server ********** --topic tmp.dummy <<< "hello"

$ kafka-console-consumer --bootstrap-server ********** --topic tmp.dummy --from-beginning --max-messages 1 --property print.offset=true
Offset:0	hello
Processed a total of 1 messages

@grongor grongor requested a review from bai as a code owner December 4, 2021 14:28
@ghost ghost added the cla-needed label Dec 4, 2021
@ghost ghost removed the cla-needed label Dec 4, 2021
@dnwe dnwe changed the title Fix wrong offsets in mock Consumer fix(test): correct wrong offsets in mock Consumer Dec 6, 2021
@dnwe dnwe added the fix label Dec 6, 2021
@dnwe dnwe force-pushed the fix-mock-partition-consumer branch from befd60d to 005a989 Compare December 7, 2021 13:02
@ghost ghost added the cla-needed label Dec 7, 2021
@dnwe
Copy link
Collaborator

dnwe commented Dec 7, 2021

@bai this is strange, I rebased the branch on main and for some reason the CLA tool is flagging up a failure, but I just merged a bunch of other PRs from @grongor that had the same GIT_AUTHOR and seemed to have passed the CLA check

@grongor
Copy link
Contributor Author

grongor commented Dec 17, 2021

So I tried signing again, but can't :/ At least I rebased the PR on the current master and fixed the fmt error.

image

@ghost ghost removed the cla-needed label Dec 17, 2021
@bai
Copy link
Contributor

bai commented Jan 13, 2022

Thanks again for contributing (and late happy hols)! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants