feat(message): add UnmarshalText method to CompressionCodec #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@vincentbernat thanks — this change looks sound to me, please can you sign the CLA? |
|
Done. Unsure how to rerun the CLA check. |
|
@vincentbernat thanks CLA is now passing — you have a couple of minor golangci-lint warnings that need fixing |
vincentbernat
force-pushed
the
feature/compression-codec-unmarshal
branch
from
79a4d64
to
8f8b02d
Compare
This allows the user to include a CompressionCodec in a structure to be unmarshaled from a configuration file using YAML/JSON/whatever.
vincentbernat
force-pushed
the
feature/compression-codec-unmarshal
branch
from
8f8b02d
to
6a516b2
Compare
|
Fixed. I have also added |
dnwe
approved these changes
Mar 28, 2022
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to include a CompressionCodec in a structure to
be unmarshaled from a configuration file using YAML/JSON/whatever.