fix: AdminClient | CreateACLs | check for error in response, return error if needed

[omris94]

While calling to CreateACLs, the errors returned from the Kafka broker are ignored. ACL creation can fail but the function returns no error.

This PR makes the function return an error if one or more AclCreationResponse.Err is not ErrNoError.

[dnwe]

Thanks for spotting this. Rather than returning the first error, should we be returning the collection of errors?
e.g.,

	errs := make([]error, 0)
	for _, res := range response.AclCreationResponses {
		if !errors.Is(res.Err, ErrNoError) {
			errs = append(errs, err)
		}
	}
	if len(errs) > 0 {
		return Wrap(ErrCreateACLs, errs...)
	}

with errors.go

// ErrCreateACLs is the type of error returned when ACL creation failed
var ErrCreateACLs = errors.New("kafka server: failed to create one or more ACLs")

[omris94]

Done 👍

[nkostoulas]

Could this explain #2167?

[dnwe]

@nkostoulas yes I believe it will

[omris94]

I added a test

[omris94]

@dnwe, I would appreciate a merge or a feedback, since we want to use the upstream instead of a branch

[dnwe]

@omris94 sure, changes look good to me so I’m happy to review and merge. We have a few more things I’d like to see go in before we’d cut a new version number, but I guess you’re happy to track via a commit in main until then?

[omris94]

@omris94 sure, changes look good to me so I’m happy to review and merge. We have a few more things I’d like to see go in before we’d cut a new version number, but I guess you’re happy to track via a commit in main until then?

@dnwe
yap , thanks :-)

[dnwe]

@omris94 great catch this one, and thank you for your first contribution!