-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIP-345: support static membership #2230
Conversation
many thanks for this contribution @aiquestion — if you are happy to go ahead and sign the Shopify CLA here then I can proceed to review the changes |
@dnwe thanks~ i think i signed the CLA before. and when i tried to sign it again, got an error "GitHub username has already signed a CLA" |
@aiquestion ah it looks like probot is confused because your first commit is under a gmail.com e-mail address that maps to your public GitHub username, but the second and third commit have been done under your company e-mail address and that isn't registered to your public GitHub account. That explains why the Please can you |
fixed it. And also revert the gomod change to avoid conflict. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aiquestion thank you, this is a really great first contribution to Sarama. Good test coverage and easy to read and understand the code changes. Thanks for your hard work!
Hi this is the impl for kip-345 static membership, pls help to take a look.