fix(balance): sort and de-deplicate memberIDs #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove balanceStrategySortable as:
- it wasn't obviously being used (as the sort.Sort was called in a
range closure over a map without updating the map value
- it had implemented a hashing scheme over topic+memberID which didn't
seem obviously superior to just using sort.StringSlice
- de-duplicate memberIDs from the consumer group metadata to avoid
incorrectly counting a given member multiple times in the assignment
dnwe
force-pushed
the
dnwe/de-duplicate-balance-strategy
branch
from
320fada
to
6750d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
range closure over a map without updating the map value
seem obviously superior to just using sort.StringSlice
incorrectly counting a given member multiple times in the assignment