Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include assignment-less members in SyncGroup #2292

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Jul 22, 2022

  • comment and rework sync_group_{request, response}
  • always send V3 SyncGroup request if config Version is 2.3.0.0 or newer
  • when sending SyncGroup as the leader, include empty assignments for
    any members that didn't receive a partition in the plan
  • update go.mod/go.sum for examples/consumergroup

Fixes #2290

- comment and rework sync_group_{request, response}
- always send V3 SyncGroup request if config Version is 2.3.0.0 or newer
- when sending SyncGroup as the leader, include empty assignments for
  any members that didn't receive a partition in the plan
- update go.mod/go.sum for examples/consumergroup

Fixes #2290
@dnwe dnwe added the fix label Jul 22, 2022
@dnwe dnwe merged commit 06d1a62 into main Jul 22, 2022
@dnwe dnwe deleted the dnwe/fix-sync-group-as-leader branch July 22, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consumer group incorrectly omits members (without any assigned partitions) from SyncGroup requests
1 participant