fix: avoid panic when Metadata.RefreshFrequency is 0 #2329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1578 ,
RefreshFrequency
is used to initialize a ticker to periodically check whether to trigger a rebalance.However, once it is set to
0
, it would cause panic when callingpause := time.NewTicker(c.config.Metadata.RefreshFrequency)
, as shown in #1999.When
RefreshFrequency
is0
, there is nobackgroundMetadataUpdater
to periodically refresh metadata. Thus, there is no need forloopCheckPartitionNumbers
as well.