Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consumer): default ResetInvalidOffsets to true #2345

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Sep 27, 2022

A number of people have reported issues with the change in default behaviour that was introduced in #2252 and the comment for this configuration value had suggested it would retain the behaviour of previous Sarama versions. This PR puts the default behaviour back to resetting to c.Consumer.Offsets.Initial when the server returns an out of range error on a Fetch.

Contributes-to: #2342

A number of people have reported issues with the change in default
behaviour that was introduced in #2252 and the comment for this
configuration value had suggested it would retain the behaviour of
previous Sarama versions. This PR puts the default behaviour back to
resetting to `c.Consumer.Offsets.Initial` when the server returns an out
of range error on a Fetch.

Contributes-to: #2342
@dnwe dnwe added the fix label Sep 27, 2022
@dnwe dnwe merged commit b6728ba into main Sep 27, 2022
@dnwe dnwe deleted the dnwe/fix-default branch September 27, 2022 20:47
remicalixte pushed a commit to remicalixte/sarama that referenced this pull request Apr 27, 2023
fix(consumer): default ResetInvalidOffsets to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant