-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(producer): return errors for every message in retryBatch to avoid producer hang forever #2378
Conversation
… the producer hang forever
CLA signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating this issue and submitting the fix, this change looks good to me
@cch123 do you think you might be able to add a functional test that covers this scenario? |
let me think about it.. I think the backoff param also didn't work, and need some time to find out why... |
chore: add test
@dnwe PTAL |
The backoff bug will be fixed in another PR |
Thanks! |
This fixes #2377