fix: add nil check while producer is retrying #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check nil and update the leader, if needed, before updating the new watermark Refs: IBM#2322
|
I put it in the draft stage first as I'm still learning the codebase, will update and make it ready when I confirm there's no side effect. |
dnwe
changed the title
dnwe
approved these changes
Dec 21, 2022
|
Thank you for your contribution, approved and merged |
hsweif
deleted the
hsuanwei.fan/fix/producer-panic-while-retrying-sending-the-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
newHighWatermarksend fin message to the input channel; it might panic when thepp.brokerProducerisnil. I added a simple check to fix it. Please help double-check if there are any unwanted side effects when you have time. Thanks a lot!