Clean up some typos and docs/help mistakes #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
|
@hindessm thanks! We should probably also enable the misspell golangci-lint checker |
dnwe
approved these changes
Jul 22, 2023
|
@hindessm interesting, not changed by your PR but it looks like the ubi default package set has seemingly changed overnight and the docker image used by the FV tests no longer has timezone files:
|
|
More puzzling is that the ubi image has tzdata package installed but is missing the /usr/share/zoneinfo files that the tzdata package contains. |
|
I've pushed a fix - |
|
Sadly I don't think that fix alone was sufficient... |
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
|
It needed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix obsolete reference to
ioutil.Discardin docs.Fix duplication of defaults in
tools/kafka-producer-performancehelp output (flag output already includes the defaults without explicitly documenting them).Fix some typos spotted while reading the code.