Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data race in Broker.AsyncProduce #2678

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: data race in Broker.AsyncProduce #2678

merged 1 commit into from
Nov 2, 2023

Conversation

lzakharov
Copy link
Contributor

Closes #2673

@lzakharov lzakharov force-pushed the fix-data-race-in-async-produce branch 4 times, most recently from d5dac42 to bab5dfd Compare October 25, 2023 12:31
@lzakharov lzakharov force-pushed the fix-data-race-in-async-produce branch from bab5dfd to c25dc27 Compare October 26, 2023 10:44
@bmassemin bmassemin mentioned this pull request Oct 27, 2023
Merged
@bmassemin
Copy link
Contributor

This fix would help stabilize our production producers. Thanks!

@dnwe dnwe added the fix label Oct 30, 2023
@lzakharov lzakharov force-pushed the fix-data-race-in-async-produce branch from c25dc27 to b22a2fb Compare October 30, 2023 16:23
@Mateusnasciment
Copy link

remove whitespace

@lzakharov lzakharov force-pushed the fix-data-race-in-async-produce branch from b22a2fb to 3da4567 Compare October 31, 2023 06:38
prestona
prestona approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@prestona prestona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

prestona
prestona requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@prestona prestona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - on reflection, I wonder if it would be better to wrap the Lock/Unlock around the assignment from b.metricsRegistry, as I think the current changes have the potential to hold the lock while the user-supplied callback is invoked (which Sarama doesn't have any control over how long this takes, or if this tries to re-enter part of Sarama that also uses the lock).

prestona
prestona approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@prestona prestona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! No. Actually the invocations to the callback are wrapped into the promise, so they won't be invoked directly from within AsyncProduce code while the lock is held.🤦

@lzakharov
fix: data race in Broker.AsyncProduce
56d5044 
Signed-off-by: Lev Zakharov <l.j.zakharov@gmail.com>
@lzakharov lzakharov force-pushed the fix-data-race-in-async-produce branch from 3da4567 to 56d5044 Compare November 1, 2023 13:42
@lzakharov
Copy link
Contributor Author

@prestona sorry for disturbing, can we merge it now?

@prestona prestona merged commit f97ced2 into IBM:main Nov 2, 2023
13 checks passed
@prestona
Copy link
Member

prestona commented Nov 2, 2023

@lzakharov - np. Merged.

@lzakharov lzakharov deleted the fix-data-race-in-async-produce branch May 21, 2024 13:08
paologallinaharbur referenced this pull request in newrelic/nri-kafka Aug 26, 2024
@renovate
fix(deps): update module github.com/ibm/sarama to v1.43.3 (#268)
b57f531 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/IBM/sarama](https://togithub.com/IBM/sarama) | `v1.41.3`
-> `v1.43.3` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fIBM%2fsarama/v1.43.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fIBM%2fsarama/v1.43.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fIBM%2fsarama/v1.41.3/v1.43.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fIBM%2fsarama/v1.41.3/v1.43.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>IBM/sarama (github.com/IBM/sarama)</summary>

### [`v1.43.3`](https://togithub.com/IBM/sarama/releases/tag/v1.43.3):
Version 1.43.3 (2024-08-12)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.43.2...v1.43.3)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

#### What's Changed

##### 🐛 Fixes

- fix: declare assignor variable for examples & clean up log format by
[@&#8203;kumakichi](https://togithub.com/kumakichi) in
[https://github.com/IBM/sarama/pull/2909](https://togithub.com/IBM/sarama/pull/2909)
- fix(consumer): maintain ordering of offset commit requests by
[@&#8203;prestona](https://togithub.com/prestona) in
[https://github.com/IBM/sarama/pull/2947](https://togithub.com/IBM/sarama/pull/2947)
- fix(producer): treat ErrKafkaStorageError as retriable by
[@&#8203;richardartoul](https://togithub.com/richardartoul) in
[https://github.com/IBM/sarama/pull/2939](https://togithub.com/IBM/sarama/pull/2939)

##### 📦 Dependency updates

- chore(deps): bump the golang-org-x group across 1 directory with 2
updates by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2956](https://togithub.com/IBM/sarama/pull/2956)
- chore(deps): bump github.com/eapache/go-resiliency from 1.6.0 to 1.7.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2944](https://togithub.com/IBM/sarama/pull/2944)
- chore(deps): bump github.com/klauspost/compress from 1.17.8 to 1.17.9
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2926](https://togithub.com/IBM/sarama/pull/2926)

##### 🔧 Maintenance

- fix(ci): correct docker-compose install by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2954](https://togithub.com/IBM/sarama/pull/2954)

##### 📝 Documentation

- fix(doc): correct JVM's config name corresponding to MaxWaitTime by
[@&#8203;abhipranay](https://togithub.com/abhipranay) in
[https://github.com/IBM/sarama/pull/2893](https://togithub.com/IBM/sarama/pull/2893)

#### New Contributors

- [@&#8203;abhipranay](https://togithub.com/abhipranay) made their first
contribution in
[https://github.com/IBM/sarama/pull/2893](https://togithub.com/IBM/sarama/pull/2893)
- [@&#8203;kumakichi](https://togithub.com/kumakichi) made their first
contribution in
[https://github.com/IBM/sarama/pull/2909](https://togithub.com/IBM/sarama/pull/2909)
- [@&#8203;richardartoul](https://togithub.com/richardartoul) made their
first contribution in
[https://github.com/IBM/sarama/pull/2939](https://togithub.com/IBM/sarama/pull/2939)

**Full Changelog**:
IBM/sarama@v1.43.2...v1.43.3

### [`v1.43.2`](https://togithub.com/IBM/sarama/releases/tag/v1.43.2):
Version 1.43.2 (2024-04-25)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.43.1...v1.43.2)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

#### What's Changed

##### 🐛 Fixes

- chore(ci): add 32-bit alignment check by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2874](https://togithub.com/IBM/sarama/pull/2874)

##### 📦 Dependency updates

- chore(deps): bump golang.org/x/net from 0.21.0 to 0.23.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2866](https://togithub.com/IBM/sarama/pull/2866)
- chore(deps): bump the golang-org-x group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2853](https://togithub.com/IBM/sarama/pull/2853)
- chore(deps): bump github.com/klauspost/compress from 1.17.7 to 1.17.8
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2857](https://togithub.com/IBM/sarama/pull/2857)
- chore(deps): bump golang.org/x/net from 0.21.0 to 0.23.0 in
/examples/txn_producer in the go_modules group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2865](https://togithub.com/IBM/sarama/pull/2865)
- chore(deps): bump golang.org/x/net from 0.21.0 to 0.23.0 in
/examples/consumergroup in the go_modules group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2867](https://togithub.com/IBM/sarama/pull/2867)
- chore(deps): bump golang.org/x/net from 0.21.0 to 0.23.0 in
/examples/exactly_once in the go_modules group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2868](https://togithub.com/IBM/sarama/pull/2868)
- chore(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 in
/examples/interceptors in the go_modules group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2869](https://togithub.com/IBM/sarama/pull/2869)

**Full Changelog**:
IBM/sarama@v1.43.1...v1.43.2

### [`v1.43.1`](https://togithub.com/IBM/sarama/releases/tag/v1.43.1):
Version 1.43.1 (2024-03-27)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.43.0...v1.43.1)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

#### What's Changed

##### 🐛 Fixes

- fix: message.max.bytes should default to
[`1048576`](https://togithub.com/IBM/sarama/commit/1048576) not 1 MB by
[@&#8203;puellanivis](https://togithub.com/puellanivis) in
[https://github.com/IBM/sarama/pull/2804](https://togithub.com/IBM/sarama/pull/2804)
- fix: add locking around broker throttle timer to prevent race
condition by [@&#8203;chengsha](https://togithub.com/chengsha) in
[https://github.com/IBM/sarama/pull/2826](https://togithub.com/IBM/sarama/pull/2826)

##### 📦 Dependency updates

- chore(deps): bump go.opentelemetry.io/otel/sdk from 1.23.1 to 1.24.0
in /examples/interceptors by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2816](https://togithub.com/IBM/sarama/pull/2816)
- chore(deps): bump the golang-org-x group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2825](https://togithub.com/IBM/sarama/pull/2825)
- chore(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2822](https://togithub.com/IBM/sarama/pull/2822)
- chore(deps): bump
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric from 1.23.1 to
1.24.0 in /examples/interceptors by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2815](https://togithub.com/IBM/sarama/pull/2815)

#### New Contributors

- [@&#8203;chengsha](https://togithub.com/chengsha) made their first
contribution in
[https://github.com/IBM/sarama/pull/2826](https://togithub.com/IBM/sarama/pull/2826)

**Full Changelog**:
IBM/sarama@v1.43.0...v1.43.1

### [`v1.43.0`](https://togithub.com/IBM/sarama/releases/tag/v1.43.0):
Version 1.43.0 (2024-02-22)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.42.2...v1.43.0)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

> \[!NOTE]\
> The go.mod directive has been bumped to 1.19 as the minimum version of
Go required for the module. This was necessary to continue to receive
updates from some of the third party dependencies that Sarama makes use
of for compression.

#### What's Changed

##### 🎉 New Features / Improvements

- feat: update go directive to 1.19 by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2795](https://togithub.com/IBM/sarama/pull/2795)
- feat: add BuildSpnFunc to GSSAPIConfig for allow custom spn by
[@&#8203;fooofei](https://togithub.com/fooofei) in
[https://github.com/IBM/sarama/pull/2807](https://togithub.com/IBM/sarama/pull/2807)

##### 🐛 Fixes

- Use %v formatting words and remove unnecessary newline by
[@&#8203;puellanivis](https://togithub.com/puellanivis) in
[https://github.com/IBM/sarama/pull/2802](https://togithub.com/IBM/sarama/pull/2802)

##### 📦 Dependency updates

- chore(deps): bump github.com/klauspost/compress from 1.16.7 to 1.17.6
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2784](https://togithub.com/IBM/sarama/pull/2784)
- chore(deps): bump github.com/eapache/go-resiliency from 1.5.0 to 1.6.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2810](https://togithub.com/IBM/sarama/pull/2810)
- chore(deps): bump github.com/klauspost/compress from 1.17.6 to 1.17.7
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2811](https://togithub.com/IBM/sarama/pull/2811)

##### 🔧 Maintenance

- chore(doc): add v1.42.2 to CHANGELOG.md by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2796](https://togithub.com/IBM/sarama/pull/2796)

#### New Contributors

- [@&#8203;puellanivis](https://togithub.com/puellanivis) made their
first contribution in
[https://github.com/IBM/sarama/pull/2802](https://togithub.com/IBM/sarama/pull/2802)
- [@&#8203;fooofei](https://togithub.com/fooofei) made their first
contribution in
[https://github.com/IBM/sarama/pull/2807](https://togithub.com/IBM/sarama/pull/2807)

**Full Changelog**:
IBM/sarama@v1.42.2...v1.43.0

### [`v1.42.2`](https://togithub.com/IBM/sarama/releases/tag/v1.42.2):
Version 1.42.2 (2024-02-09)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.42.1...v1.42.2)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

#### What's Changed

> \[!NOTE]\
> The go.mod directive has been bumped to 1.18 as the minimum version of
Go required for the module. This was necessary to continue to receive
updates from some of the third party dependencies that Sarama makes use
of for compression.

##### 🎉 New Features / Improvements

- feat: update go directive to 1.18 by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2713](https://togithub.com/IBM/sarama/pull/2713)
- feat: return KError instead of errors in AlterConfigs and
DescribeConfig by [@&#8203;zhuliquan](https://togithub.com/zhuliquan) in
[https://github.com/IBM/sarama/pull/2472](https://togithub.com/IBM/sarama/pull/2472)

##### 🐛 Fixes

- fix: don't waste time for backoff on member id required error by
[@&#8203;lzakharov](https://togithub.com/lzakharov) in
[https://github.com/IBM/sarama/pull/2759](https://togithub.com/IBM/sarama/pull/2759)
- fix: prevent ConsumerGroup.Close infinitely locking by
[@&#8203;maqdev](https://togithub.com/maqdev) in
[https://github.com/IBM/sarama/pull/2717](https://togithub.com/IBM/sarama/pull/2717)

##### 📦 Dependency updates

- chore(deps): bump golang.org/x/net from 0.17.0 to 0.18.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2716](https://togithub.com/IBM/sarama/pull/2716)
- chore(deps): bump golang.org/x/sync to v0.5.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2718](https://togithub.com/IBM/sarama/pull/2718)
- chore(deps): bump github.com/pierrec/lz4/v4 from 4.1.18 to 4.1.19 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2739](https://togithub.com/IBM/sarama/pull/2739)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2748](https://togithub.com/IBM/sarama/pull/2748)
- chore(deps): bump the golang-org-x group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2734](https://togithub.com/IBM/sarama/pull/2734)
- chore(deps): bump the golang-org-x group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2764](https://togithub.com/IBM/sarama/pull/2764)
- chore(deps): bump github.com/pierrec/lz4/v4 from 4.1.19 to 4.1.21 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2763](https://togithub.com/IBM/sarama/pull/2763)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in
/examples/exactly_once by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2749](https://togithub.com/IBM/sarama/pull/2749)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in
/examples/consumergroup by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2750](https://togithub.com/IBM/sarama/pull/2750)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in
/examples/sasl_scram_client by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2751](https://togithub.com/IBM/sarama/pull/2751)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in
/examples/interceptors by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2752](https://togithub.com/IBM/sarama/pull/2752)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in
/examples/http_server by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2753](https://togithub.com/IBM/sarama/pull/2753)
- chore(deps): bump github.com/eapache/go-resiliency from 1.4.0 to 1.5.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2745](https://togithub.com/IBM/sarama/pull/2745)
- chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in
/examples/txn_producer by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2754](https://togithub.com/IBM/sarama/pull/2754)
- chore(deps): bump go.opentelemetry.io/otel/sdk from 1.19.0 to 1.22.0
in /examples/interceptors by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2767](https://togithub.com/IBM/sarama/pull/2767)
- chore(deps): bump the golang-org-x group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2793](https://togithub.com/IBM/sarama/pull/2793)
- chore(deps): bump
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric from 0.42.0 to
1.23.1 in /examples/interceptors by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/IBM/sarama/pull/2792](https://togithub.com/IBM/sarama/pull/2792)

##### 🔧 Maintenance

- fix(examples): housekeeping of code and deps by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2720](https://togithub.com/IBM/sarama/pull/2720)

##### ➕ Other Changes

- fix(test): retry MockBroker Listen for EADDRINUSE by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2721](https://togithub.com/IBM/sarama/pull/2721)

#### New Contributors

- [@&#8203;maqdev](https://togithub.com/maqdev) made their first
contribution in
[https://github.com/IBM/sarama/pull/2717](https://togithub.com/IBM/sarama/pull/2717)
- [@&#8203;zhuliquan](https://togithub.com/zhuliquan) made their first
contribution in
[https://github.com/IBM/sarama/pull/2472](https://togithub.com/IBM/sarama/pull/2472)

**Full Changelog**:
IBM/sarama@v1.42.1...v1.42.2

### [`v1.42.1`](https://togithub.com/IBM/sarama/releases/tag/v1.42.1):
Version 1.42.1 (2023-11-07)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.42.0...v1.42.1)

#### What's Changed

##### 🐛 Fixes

- fix: make fetchInitialOffset use correct protocol by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2705](https://togithub.com/IBM/sarama/pull/2705)
- fix(config): relax ClientID validation after 1.0.0 by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2706](https://togithub.com/IBM/sarama/pull/2706)

**Full Changelog**:
IBM/sarama@v1.42.0...v1.42.1

### [`v1.42.0`](https://togithub.com/IBM/sarama/releases/tag/v1.42.0):
Version 1.42.0 (2023-11-02)

[Compare
Source](https://togithub.com/IBM/sarama/compare/v1.41.3...v1.42.0)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

#### What's Changed

##### 🐛 Fixes

- Asynchronously close brokers during a RefreshBrokers by
[@&#8203;bmassemin](https://togithub.com/bmassemin) in
[https://github.com/IBM/sarama/pull/2693](https://togithub.com/IBM/sarama/pull/2693)
- Fix data race on Broker.done channel by
[@&#8203;prestona](https://togithub.com/prestona) in
[https://github.com/IBM/sarama/pull/2698](https://togithub.com/IBM/sarama/pull/2698)
- fix: data race in Broker.AsyncProduce by
[@&#8203;lzakharov](https://togithub.com/lzakharov) in
[https://github.com/IBM/sarama/pull/2678](https://togithub.com/IBM/sarama/pull/2678)
- Fix default retention time value in offset commit by
[@&#8203;prestona](https://togithub.com/prestona) in
[https://github.com/IBM/sarama/pull/2700](https://togithub.com/IBM/sarama/pull/2700)
- fix(txmgr): ErrOffsetsLoadInProgress is retriable by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2701](https://togithub.com/IBM/sarama/pull/2701)

##### 🔧 Maintenance

- chore(ci): improve ossf scorecard result by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2685](https://togithub.com/IBM/sarama/pull/2685)
- chore(ci): add kafka 3.6.0 to FVT and versions by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2692](https://togithub.com/IBM/sarama/pull/2692)

##### ➕ Other Changes

- chore(ci): ossf scorecard.yml by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2683](https://togithub.com/IBM/sarama/pull/2683)
- fix(ci): always run CodeQL on every commit by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2689](https://togithub.com/IBM/sarama/pull/2689)
- chore(doc): add OpenSSF Scorecard badge by
[@&#8203;dnwe](https://togithub.com/dnwe) in
[https://github.com/IBM/sarama/pull/2691](https://togithub.com/IBM/sarama/pull/2691)

#### New Contributors

- [@&#8203;bmassemin](https://togithub.com/bmassemin) made their first
contribution in
[https://github.com/IBM/sarama/pull/2693](https://togithub.com/IBM/sarama/pull/2693)
- [@&#8203;lzakharov](https://togithub.com/lzakharov) made their first
contribution in
[https://github.com/IBM/sarama/pull/2678](https://togithub.com/IBM/sarama/pull/2678)

**Full Changelog**:
IBM/sarama@v1.41.3...v1.42.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/newrelic/nri-kafka).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestona prestona prestona approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race found in the async producer
5 participants
@lzakharov @bmassemin @Mateusnasciment @prestona @dnwe