Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): relax ClientID validation after 1.0.0 #2706

Merged
merged 1 commit into from
Nov 7, 2023

Commits on Nov 7, 2023

  1. fix(config): relax ClientID validation after 1.0.0

    The original validation regex was based on the one that existed in the
    Java clients pre-1.0.0 but KIP-190 removed the client-side validation
    because instead the brokers were updated to be able to cope with any
    clientID and sanitize it before using it in metrics etc.
    
    We can do similar in Sarama and only do client-side validation when the
    user has specified a version number older than 1.0.0
    
    Fixes #2697
    
    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    dnwe committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c08d93e View commit details
    Browse the repository at this point in the history