Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metadata disable full scan #2830

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

famarting
Copy link

The changes in this PR address, but don't fix directly, this issues:

Also this will be of great help in Dapr: dapr/components-contrib#3247

With this changes now it will be possible to set config.Metadata.Full = false but it would require the user to set a topic via
config.Metadata.InitialTopics = []string{"dummy-topic"} , with this the first request to fetch the metadata will either create that topic if it doesn't exist or it will just fetch its metadata

Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Copy link

github-actions bot commented Jun 9, 2024

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur.
If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Jun 9, 2024
@famarting
Copy link
Author

ping, is there any interest in this contribution? I'm happy to debate it further or change anything that is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant