Make mockbroker part of the _test code #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smart. The alternative is using an interface instead of testing.T like I did in sarama/mocks, but I guess this is OK as a stopgap measure. |
|
It did use an interface when it was public and part of the core API, but I removed it when we made it private, not thinking that without the rename it would still get built into the core package :P |
eapache
added a commit
that referenced
this pull request
Mar 11, 2015
Make mockbroker part of the _test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #312 lands it in its own package, we should avoid pulling go's testing lib
into the production library. Fixes #334.
cc @Shopify/kafka