producer: wrap partitioning in a circuit-breaker #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents repeatedly broken topics (e.g. ones that don't even exist) from choking throughput for other topics.
| @@ -265,10 +265,13 @@ func (p *asyncProducer) topicDispatcher() { | |||
| func (p *asyncProducer) partitionDispatcher(topic string, input chan *ProducerMessage) { | |||
| handlers := make(map[int32]chan *ProducerMessage) | |||
| partitioner := p.conf.Producer.Partitioner(topic) | |||
| breaker := breaker.New(3, 1, 10*time.Second) | |||
There was a problem hiding this comment.
We have a bunch of circuit breakers with hard-coded settings now. Should we make the circuit breaker options available in the Config struct?
There was a problem hiding this comment.
"a bunch" is 2, and they currently have the same settings. We might want to expose those parameters, I'm not sure if anybody really actually cares to tweak them.
There was a problem hiding this comment.
In other words, I just don't care to do that work until somebody actually wants or needs it.
|
LGTM. |
eapache
added a commit
that referenced
this pull request
Mar 19, 2015
producer: wrap partitioning in a circuit-breaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents repeatedly broken topics (e.g. ones that don't even exist) from
choking throughput for other topics.
@Shopify/kafka
No tests because: