Add retry logic to GetOffset() just like Leader() #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is: refresh the metadata and retry once, in case e.g. our connection or metadata is stale. Also add a test for it.
| } | ||
|
|
||
| return block.Offsets[0], nil | ||
| return offset, err |
There was a problem hiding this comment.
So this will basically do endless retries, as long a RefreshMetadata doesn't return an error? Is that something we should watch out for?
There was a problem hiding this comment.
Actually nvm, it just does one retry. I imagined a for loop that isn't there.
|
This is a nice improvement 👍 |
eapache
added a commit
that referenced
this pull request
Apr 7, 2015
Add retry logic to GetOffset() just like Leader()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is: refresh the metadata and retry once, in case e.g. our connection or
metadata is stale.
Also add a test for it.
@Shopify/kafka