Producer logging tweaks #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in leaderDispatcher, make the topic/partition part of the initial log slug for convenience and consistency - don't log on every switch from normal to flushing in the loop, just the first, since 99% of the time we burn right through them all and we only need one line to indicate that, not 5 or 10 - similarly, don't log on every switch from flushing to normal, just do so if the highWatermark is 0 and it breaks the loop - in combination with the previous change we end up with just an entry and exit log for the loop, rather than two logs per iteration - in messageAggregator, make the broker ID part of the slug (it wasn't even logged before)
eapache
force-pushed
the
producer-loggin
branch
from
aed667f
to
52110d0
Compare
|
🆒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convenience and consistency
since 99% of the time we burn right through them all and we only need one line
to indicate that, not 5 or 10
the highWatermark is 0 and it breaks the loop - in combination with the
previous change we end up with just an entry and exit log for the loop, rather
than two logs per iteration
logged before)
@Shopify/kafka