Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffsetManager Implementation #461

Merged
merged 24 commits into from
Aug 24, 2015
Merged

OffsetManager Implementation #461

merged 24 commits into from
Aug 24, 2015

Commits on Aug 18, 2015

  1. First draft implementation of an offset manager

    Still a bunch of open questions, but this is reasonably functional at least.
    eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    e0c0da8 View commit details
    Browse the repository at this point in the history
  2. Track dirty flag in partition-offset-manager

    Necessary first step for safe shutdown.
    eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    90ba479 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7d8e17 View commit details
    Browse the repository at this point in the history
  4. Don't start setting until the initial get succeeds

    Divorce selecting the appropriate broker with subscribing to that broker, they
    have to be separate actions.
    
    Thanks to Aaron Kavlie for finding the bug.
    eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    9e2380c View commit details
    Browse the repository at this point in the history
  5. Only add dirty subscriptions to the request

    Also handle if the request ends up empty because all of the subscriptions were
    clean.
    eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    b4fb5b7 View commit details
    Browse the repository at this point in the history
  6. Fix abort()

    Add a missing return, and zero out the subscriptions when we're done.
    eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    9d4ca02 View commit details
    Browse the repository at this point in the history
  7. Fix some error return codes

    aaronkavlie-wf authored and eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    e98389a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    84abfe4 View commit details
    Browse the repository at this point in the history
  9. Start offset manager tests

    Cover POM init, setting and getting offsets.
    
    Separate out test bootstrapping into init function.
    aaronkavlie-wf authored and eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    1d96533 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5f0a997 View commit details
    Browse the repository at this point in the history
  11. Test of one fetchInitialOffset error

    Includes fix to error returns in offset_manager.go
    aaronkavlie-wf authored and eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    71aee66 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    67f88f7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    132f582 View commit details
    Browse the repository at this point in the history
  14. Test to covert abort process.

    Includes small fix to offset manager -- return to avoid
    checking nil response.
    aaronkavlie-wf authored and eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    147e2fe View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    50afd11 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2ad9fa7 View commit details
    Browse the repository at this point in the history
  17. Misc. small changes to address PR feedback

    - Make test function names more verbose (for targeting with -run)
    - safeClose io.Closers to catch errors
    - Remove debugging time.Sleep call
    - Don't use globals for client, brokers, etc.
    aaronkavlie-wf authored and eapache committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    33f2f9f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2015

  1. Configuration menu
    Copy the full SHA
    1e19f5c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e8c4f2 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #518 from Shopify/offset-manager-close

    Add Close() OffsetManager interface
    wvanbergen committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    de8e312 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2015

  1. Configuration menu
    Copy the full SHA
    5109f97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e8c3c16 View commit details
    Browse the repository at this point in the history
  3. Deregister a partition offset manager in the OffsetManager when it is…

    … done, so we can register a new one later.
    wvanbergen committed Aug 21, 2015
    Configuration menu
    Copy the full SHA
    0ae0505 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #520 from Shopify/offset-manager-initial

    Offset manager: make initial offset configurable
    wvanbergen committed Aug 21, 2015
    Configuration menu
    Copy the full SHA
    4c0d6fc View commit details
    Browse the repository at this point in the history