-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OffsetManager Implementation #461
Commits on Aug 18, 2015
-
First draft implementation of an offset manager
Still a bunch of open questions, but this is reasonably functional at least.
Configuration menu - View commit details
-
Copy full SHA for e0c0da8 - Browse repository at this point
Copy the full SHA e0c0da8View commit details -
Track dirty flag in partition-offset-manager
Necessary first step for safe shutdown.
Configuration menu - View commit details
-
Copy full SHA for 90ba479 - Browse repository at this point
Copy the full SHA 90ba479View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d8e17 - Browse repository at this point
Copy the full SHA e7d8e17View commit details -
Don't start setting until the initial get succeeds
Divorce selecting the appropriate broker with subscribing to that broker, they have to be separate actions. Thanks to Aaron Kavlie for finding the bug.
Configuration menu - View commit details
-
Copy full SHA for 9e2380c - Browse repository at this point
Copy the full SHA 9e2380cView commit details -
Only add dirty subscriptions to the request
Also handle if the request ends up empty because all of the subscriptions were clean.
Configuration menu - View commit details
-
Copy full SHA for b4fb5b7 - Browse repository at this point
Copy the full SHA b4fb5b7View commit details -
Add a missing return, and zero out the subscriptions when we're done.
Configuration menu - View commit details
-
Copy full SHA for 9d4ca02 - Browse repository at this point
Copy the full SHA 9d4ca02View commit details -
Configuration menu - View commit details
-
Copy full SHA for e98389a - Browse repository at this point
Copy the full SHA e98389aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84abfe4 - Browse repository at this point
Copy the full SHA 84abfe4View commit details -
Cover POM init, setting and getting offsets. Separate out test bootstrapping into init function.
Configuration menu - View commit details
-
Copy full SHA for 1d96533 - Browse repository at this point
Copy the full SHA 1d96533View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f0a997 - Browse repository at this point
Copy the full SHA 5f0a997View commit details -
Test of one fetchInitialOffset error
Includes fix to error returns in offset_manager.go
Configuration menu - View commit details
-
Copy full SHA for 71aee66 - Browse repository at this point
Copy the full SHA 71aee66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67f88f7 - Browse repository at this point
Copy the full SHA 67f88f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 132f582 - Browse repository at this point
Copy the full SHA 132f582View commit details -
Includes small fix to offset manager -- return to avoid checking nil response.
Configuration menu - View commit details
-
Copy full SHA for 147e2fe - Browse repository at this point
Copy the full SHA 147e2feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50afd11 - Browse repository at this point
Copy the full SHA 50afd11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ad9fa7 - Browse repository at this point
Copy the full SHA 2ad9fa7View commit details -
Misc. small changes to address PR feedback
- Make test function names more verbose (for targeting with -run) - safeClose io.Closers to catch errors - Remove debugging time.Sleep call - Don't use globals for client, brokers, etc.
Configuration menu - View commit details
-
Copy full SHA for 33f2f9f - Browse repository at this point
Copy the full SHA 33f2f9fView commit details
Commits on Aug 19, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 1e19f5c - Browse repository at this point
Copy the full SHA 1e19f5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e8c4f2 - Browse repository at this point
Copy the full SHA 1e8c4f2View commit details -
Merge pull request #518 from Shopify/offset-manager-close
Add Close() OffsetManager interface
Configuration menu - View commit details
-
Copy full SHA for de8e312 - Browse repository at this point
Copy the full SHA de8e312View commit details
Commits on Aug 21, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 5109f97 - Browse repository at this point
Copy the full SHA 5109f97View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8c3c16 - Browse repository at this point
Copy the full SHA e8c3c16View commit details -
Deregister a partition offset manager in the OffsetManager when it is…
… done, so we can register a new one later.
Configuration menu - View commit details
-
Copy full SHA for 0ae0505 - Browse repository at this point
Copy the full SHA 0ae0505View commit details -
Merge pull request #520 from Shopify/offset-manager-initial
Offset manager: make initial offset configurable
Configuration menu - View commit details
-
Copy full SHA for 4c0d6fc - Browse repository at this point
Copy the full SHA 4c0d6fcView commit details