Clean up aggregator via helper methods #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also get rid of forceFlushThreshold it does not need its own function
eapache
force-pushed
the
cleanup-aggregator
branch
from
24a1ed8
to
765b3b4
Compare
| func (a *aggregator) wouldOverflow(msg *ProducerMessage) bool { | ||
| switch { | ||
| // Would we overflow our maximum possible size-on-the-wire? 10KiB is arbitrary overhead for safety. | ||
| case a.bufferBytes+msg.byteSize() >= int(MaxRequestSize-(10*1024)): |
There was a problem hiding this comment.
Can we trust the compiler to optimize the static calculation into a constant?
There was a problem hiding this comment.
We weren't before and nobody ever complained...
|
👍 this one is pretty straightforward |
eapache
added a commit
that referenced
this pull request
Aug 13, 2015
Clean up aggregator via helper methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also get rid of forceFlushThreshold it does not need its own function
@wvanbergen