Fix and simplify message decoding #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't short-circuit return when inflating compressed messages. There are no other fields left, but we should still check the wrapping message's CRC32. - Do short-circuit return that CRC32 field, it's the last thing we do so there's no need for a manual if-not-nil return.
|
👍 |
eapache
added a commit
that referenced
this pull request
Aug 31, 2015
Fix and simplify message decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other fields left, but we should still check the wrapping message's CRC32.
no need for a manual if-not-nil return.
@Shopify/kafka found while testing #527