Commits on Sep 30, 2015

1. Make dead brokers die harder …

   When a broker gets an error trying to receive a response (either from the
   network layer, or from failing to parse the minimal global header), it should
   just abandon ship and die. Save that error and return it immediately for any
   further requests we might have made.
   
   - The vast majority of the time the connection is going to be hosed anyways, if
     nothing else by being out-of-sync on correlation IDs (which we don't handle
     and which doesn't seem particularly urgent).
   - All of Sarama's built-in callers (producer/consumer/offset-manager)
     immediately `Close` a broker when they receive one of these errors anyways, so
     all this does is speed up that in the common case.
   
   *If* one of these errors is recoverable, and *if* there is user-space code
   somewhere which actually tries to recover in one of those cases, then that code
   would break.
   
   This neatly satisfies one of the XXX comments I left in about this issue from
   way back in 2013. The TODOs about correlation ID matching are still present.

   

   eapache committed Sep 30, 2015
   Configuration menu

   • View commit details
   • Copy full SHA for b51603a
   • Browse repository at this point

   Copy the full SHA

   b51603a View commit details

   Browse the repository at this point in the history