Add support for SASL plain text authentication #648
Conversation
| @@ -222,6 +233,7 @@ func NewConfig() *Config { | |||
| c.Net.DialTimeout = 30 * time.Second | |||
| c.Net.ReadTimeout = 30 * time.Second | |||
| c.Net.WriteTimeout = 30 * time.Second | |||
| c.Net.SASL.Enable = false | |||
There was a problem hiding this comment.
you don't need to set this, false is the default for go booleans
|
Hi, I have addressed all of your comments. See if this version of PR is good enough. |
| if conf.Net.SASL.Enable { | ||
| err = b.doSASLPlainAuth() | ||
| if err != nil { | ||
| Logger.Printf("SASL authentication with broker %s failed\n", b.addr) |
There was a problem hiding this comment.
you log every case in doSASLPlainAuth and both cases here, that seems a bit much?
|
Any pointers as to why the build fails with Go 1.6.1 ? The log seems to go on for ever. |
|
It's just a test that occasionally gets stuck; I've restarted it and it should pass this time. |
|
This looks OK to me now I think; @wvanbergen ? |
| // When credentials are valid, Kafka returns a 4 byte array of null characters. | ||
| // When credentials are invalid, Kafka closes the connection. This does not seem to be the ideal way | ||
| // of responding to bad credentials but thats how its being done today. | ||
| func (b *Broker) doSASLPlainAuth() error { |
There was a problem hiding this comment.
as name, I prefer sendAndReceiveSASLPlainAuth which is more in line with naming we have elsewhere
|
Hi |
|
I am ok with merging this 👍. @eapache I will let you do the honours |
|
👍 thanks |
Hi
This is a simple patch that adds support for SASL plain text authentication to Kafka brokers, if enabled. This feature is useful when people want to leverage hosted Kafka services such as IBM Bluemix's Message Hub service (Kafka 0.9 with SASL plain text authentication). By default, the authentication is disabled.