Forbid empty ClientID and use 'sarama' as default #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation states that
"sarama"
is the default ClientID but the empty string actually is used.This is a not a problem for connecting to the brokers but it creates issues when settings policies against the tools binaries (e.g.
kafka-console-producer
) like:Fix uses
"sarama"
as the default ClientID following the documentation and also forbids the empty string (test case provided).