add relative offset handling for 0.10+ compressed msgs #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, msg := range msgBlock.Messages() { | ||
| if prelude && msg.Offset < child.offset { | ||
| offset := msg.Offset | ||
| if child.conf.Version.IsAtLeast(V0_10_0_0) { |
There was a problem hiding this comment.
If I'm reading the docs properly, this condition should be based on msg.Msg.Version since 0.10 brokers can still use the old format in some configurations.
|
Thanks for figuring this out, and sorry for the delay, I've been unfortunately busy with other projects recently. I left a few notes to ensure we handle all the cases properly, but I think this is effectively the right fix. |
eapache
added a commit
that referenced
this pull request
Aug 23, 2016
New message format does something weird with these. See https://cwiki.apache.org/confluence/display/KAFKA/KIP-31+-+Move+to+relative+offsets+in+compressed+message+sets Fixes #720. Supercedes #721. Thanks to @dynamix for the first draft of the fix.
|
#735 does is indeed the correct fix. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempted fix for #720