-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lz4 compression #786
Add lz4 compression #786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine. Two requests:
- Please add a test in
message_test.go
? - Please guard this against the configured Kafka version so that if somebody tries to use it against an older Kafka version they get a useful error instead of weird misbehaviour.
config.Validate checks for versions < V0_10 and errs if LZ4 is enabled. Will add a message test later today. |
@eapache encode / decode test, config check + tests. |
Hm, the failed test looks like a false positive to me. |
Ya, I've rerun it. Sometimes the broker just doesn't start properly on CI for some reason. |
Thanks! |
This patch may cause issues with kafka < 0.10.0 as it doesn't handle "broken" framing.
It should thus only be used with 0.10+.