Added support for FetchRequest protocol version 3. #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2017 12:19
This commit will add the 'MaxBytes' field to FetchRequests when the Kafka version is 0.10.1 or better. On send, it will be set to MaxResponseSize. No tests, yet.
This commit adds support for version 3 of the FetchRequest API. The
KIP can be found here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-74%3A+Add+Fetch+Response+Size+Limit+in+Bytes
the PR here:
apache/kafka#1812
and the JIRA here:
https://issues.apache.org/jira/browse/KAFKA-2063
Should document the fact that the per-partition limits take
precedence (so the returned message may be larger than the
requested limit).
eapache
reviewed
Jun 30, 2017
fetch_request.go
Outdated
| @@ -32,6 +36,9 @@ func (r *FetchRequest) encode(pe packetEncoder) (err error) { | |||
| pe.putInt32(-1) // replica ID is always -1 for clients | |||
| pe.putInt32(r.MaxWaitTime) | |||
| pe.putInt32(r.MinBytes) | |||
| if 3 == r.Version { | |||
There was a problem hiding this comment.
r.Version == 3 is more consistent with the rest of the code, and with the check you added below
There was a problem hiding this comment.
Old habits die hard; fixed in my latest commit.
consumer.go
Outdated
| @@ -726,6 +726,10 @@ func (bc *brokerConsumer) fetchNewMessages() (*FetchResponse, error) { | |||
| if bc.consumer.conf.Version.IsAtLeast(V0_10_0_0) { | |||
| request.Version = 2 | |||
| } | |||
| if bc.consumer.conf.Version.IsAtLeast(V0_10_1_0) { | |||
| request.Version = 3 | |||
| request.MaxBytes = MaxResponseSize - 47 // TODO(mherstin): WTF?! | |||
There was a problem hiding this comment.
I agree with the comment: where did the value of 47 come from?
There was a problem hiding this comment.
That's embarrassing-- this was removed in a subsequent commit which I forgot to push. Fixed.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add the 'MaxBytes' field to FetchRequests when the Kafka version is
0.10.1 or better (i.e. it adds support for V3 of the FetchRequest API). On send, it will be set to MaxResponseSize.