Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka 1.0.0 to travis and as kafka version constant #984

Merged
merged 2 commits into from
Nov 20, 2017
Merged

add kafka 1.0.0 to travis and as kafka version constant #984

merged 2 commits into from
Nov 20, 2017

Conversation

buyology
Copy link

fixes #983

anything I'm overlooking atm?

strictly speaking I guess the version is V1_0_0 rather than V1_0_0_0 now that it has moved to 1.*. should we keep it for symmetry though?

@buyology
Copy link
Author

xref #985 (comment)

should we also

  • remove 0.9?
  • bump 0.11.0.1 to 0.11.0.2?

@eapache
Copy link
Contributor

eapache commented Nov 20, 2017

strictly speaking I guess the version is V1_0_0 rather than V1_0_0_0 now that it has moved to 1.*. should we keep it for symmetry though?

Ya, especially since there's a bunch of logic that assumes all versions have four places and would break if we changed it to three.

anything I'm overlooking atm?

Update the compat section of the README?

remove 0.9?
bump 0.11.0.1 to 0.11.0.2?

Yes please. 0.9 is well out of our 2+2 window, I've just been lazy about removing it.

@eapache eapache mentioned this pull request Nov 20, 2017
@eapache
Copy link
Contributor

eapache commented Nov 20, 2017

Thanks!

@eapache eapache merged commit 9ea1af8 into IBM:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Kafka 1.0 to Travis + KafkaVersion constant
2 participants