Permit setting version on mock produce response #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looks fine to me, but CI is complaining about the formatting? |
This allows setting the version of the message data struct for MockProduceResponse. This change is very similar to what was already done in pull request IBM#939 In order to mock a "produce" request for Kafka version 0.10.2.0 you would use the following: leader.SetHandlerByMap(map[string]MockResponse{ "ProduceRequest": NewMockProduceResponse(t). SetVersion(2). SetError("my_topic", 0, ErrNoError), })
fgrosse
force-pushed
the
v2-mock-produce-responses
branch
from
8dbfcc7
to
5169c31
Compare
|
Sorry for the late reply. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting the version of the message data struct for
MockProduceResponse. This change is very similar to what was already
done in pull request #939
In order to mock a "produce" request for Kafka version 0.10.2.0 you
would use the following: