Minor refactors, bugfix, features and test additions #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segeljakt
changed the title
scotts
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of minor improvements. The most important change is in Reactive. I found a bug in my implementation which only happens when FlatFat contains only one element which is both a leaf and a root node. When updating a leaf node, I need to access its parent. The program crashed because the root node has no parent. Reactive now ensures that a leaf cannot be a root by never resizing if there is only one element in the window. This is the part of the Reactive algorithm I'm referring to. The bug happened when
leaf(loci) = T.root.I realised I also somehow forgot to make the Reactive-FlatFat buffer circular 👀 It should be fixed now.
The PR in addition adds some small extension methods to FifoWindows:
lenmethod for calculating the number of elements in a window.is_emptymethod for calculating if a window is empty.