Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix/ub 1431 fix glog errors in provisioner #212

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

olgashtivelman
Copy link
Collaborator

@olgashtivelman olgashtivelman commented Sep 13, 2018

currently there are errors filling the provisioner logs that look like this:
ERROR: logging before flag.Parse: I0716 13:33:58.655590 1 controller.go:1063] volume "ibm-ubiquity-db" deleted from database ERROR: logging before flag.Parse: I0716 13:34:00.224200 1 controller.go:826] volume "ibm-ubiquity-db" for claim "ubiquity/ibm-
they seem to be caused by some change in glog (used by kuberentes)
this small fix removes them from the log.

(fix was taking from : cloudnativelabs/kube-router@78a0aeb )


This change is Reviewable

Copy link
Contributor

@shay-berman shay-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

(BUT please see my comment below before merge)

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman and @shay-berman)


cmd/provisioner/main/main.go, line 44 at r1 (raw file):

	/* this is fixing an existing issue with glog in kuberenetes in version 1.9
		if we ever move to a newer code version this can be removed.

if you can please put the link where you find that this fix the issue. Do you have any idea what will happened if we will upgrade to k8s 1.10 dependencies? it means that it will fail?

Copy link
Collaborator Author

@olgashtivelman olgashtivelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman)


cmd/provisioner/main/main.go, line 44 at r1 (raw file):

Previously, shay-berman wrote…

if you can please put the link where you find that this fix the issue. Do you have any idea what will happened if we will upgrade to k8s 1.10 dependencies? it means that it will fail?

the link is in the PR already.
in kubernetes 1.10 as I understand glog is not longer used. not sure this will cause issued since it is just setting a glog flag, i think this will just be redundant.

Copy link
Collaborator Author

@olgashtivelman olgashtivelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shay-berman)


cmd/provisioner/main/main.go, line 44 at r1 (raw file):

Previously, olgashtivelman wrote…

the link is in the PR already.
in kubernetes 1.10 as I understand glog is not longer used. not sure this will cause issued since it is just setting a glog flag, i think this will just be redundant.

Done.

@olgashtivelman olgashtivelman merged commit ccb3bb4 into dev Sep 25, 2018
@olgashtivelman olgashtivelman deleted the fix/UB-1431_fix_glog_erros branch September 25, 2018 08:30
deeghuge pushed a commit that referenced this pull request Oct 4, 2018
… PV mountpoint (#209)

- Added idempotent changes for IsAttached/Attach/Detach operations.
- For SpectrumScale backend IsAttached/Attach/Detach will return "Not Supported".
- fixed lnpath for spectrum scale
- Added new function getMountpointForVolume which will return apprpriate mountpoint based on respective backends.
- Added UT for changes 

Additional changes pulled in this PR because of rebase. 
- UB-1491: Add log message for flex detach (#208)
- Ub-599: fiscover by sg_ibq continue on bad mpath device
- Fix/ub 1431 fix glog errors in provisioner (#212)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants